Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: disable aspect_bazelrc_presets tests in non-bzlmod #1982

Merged
merged 1 commit into from
Oct 16, 2024
Merged

build: disable aspect_bazelrc_presets tests in non-bzlmod #1982

merged 1 commit into from
Oct 16, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 16, 2024

main is currently failing with non-bzlmod due to workspace and bzlmod resolving to different versions

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from dzbarsky October 16, 2024 21:27
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Oct 16, 2024 •
edited
Loading

Test

All tests were cache hits

203 tests (100.0%) were fully cached saving 40s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 789ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 184ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 920ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 924ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 296ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 112ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 254ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 236ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 504ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 493ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 153ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 413ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 171ms.

Buildifier      Format

@jbedard jbedard merged commit 31bf0e3 into aspect-build:main Oct 16, 2024
65 of 70 checks passed
@jbedard jbedard deleted the bazelrc-bzlmod-only branch October 16, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzbarsky dzbarsky dzbarsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @dzbarsky